A good mystery story usually has a puzzling crime or mystery to solve, interesting characters with hidden motives, and plenty of clues and red herrings to keep you guessing.
A great mystery story typically involves a mysterious event that's hard to figure out at first. It has diverse characters, each with their own secrets. Plus, it should have a logical but not too obvious solution that leaves you satisfied when it's revealed.